Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add port config #230

Merged
merged 5 commits into from
Feb 1, 2021
Merged

Add port config #230

merged 5 commits into from
Feb 1, 2021

Conversation

hesstobi
Copy link
Contributor

I liked to configure the port the server is running on. This mr add this options.

Please let me know if there are any changes required.

Copy link
Owner

@thomseddon thomseddon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this change - thanks!

Please could I ask that you:

  • Change the text from "port the server is running on" to "port to listen on"
  • Please ensure the text in the readme exactly matches the output of --help

@thomseddon thomseddon added enhancement New feature or request under review labels Jan 31, 2021
@hesstobi
Copy link
Contributor Author

hesstobi commented Feb 1, 2021

Yes of course. The requested changes are implemented.

@thomseddon thomseddon merged commit 6c6f75e into thomseddon:master Feb 1, 2021
@thomseddon
Copy link
Owner

Awesome, thanks 👍

mkska pushed a commit to mkska/traefik-forward-auth that referenced this pull request Aug 22, 2023
Co-authored-by: Tobias Hess <tobias.hess@energiekoppler.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request under review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants